-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-15543#Improved environment variable parsing for ImagePaths #100338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
56681ac
to
d35caa7
Compare
d35caa7
to
b072dfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the mentioned nits, everything looks good. Thanks.
/label qe-approved |
b072dfa
to
132f531
Compare
New changes are detected. LGTM label has been removed. |
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick enterprise-4.20 |
@lpettyjo: new pull request created: #100551 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.20 only
Issue: https://issues.redhat.com/browse/OSDOCS-15543
Link to docs preview: https://100338--ocpdocs-pr.netlify.app/openshift-enterprise/latest/disconnected/mirroring/about-installing-oc-mirror-v2#oc-mirror-imageset-config-parameters-v2_about-installing-oc-mirror-v2
QE review:
Additional information:
Rel Notes entry PR: #100352